ref(insights): remove eap conditions caches/queues/database #95230
Conversation
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95230 +/- ##
==========================================
+ Coverage 87.83% 87.85% +0.02%
==========================================
Files 10481 10469 -12
Lines 606068 604768 -1300
Branches 23674 23624 -50
==========================================
- Hits 532324 531332 -992
+ Misses 73380 73076 -304
+ Partials 364 360 -4 |
DominikB2014
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Bug: Undefined Filters Parameter Causes TypeError
Spreading the optional filters parameter directly into MutableSearch.fromQueryObject() can cause a runtime TypeError when filters is undefined.
static/app/views/insights/common/components/fullSpanDescription.tsx#L35-L36
Bug: Malformed API URLs in `useRelease` Hook
The useRelease hook can generate malformed API URLs with a double slash (e.g., /projects/org-slug//releases/1.0.0/). This happens because the projectSlug parameter is derived from project?.slug ?? ''. If project is undefined (e.g., when indexedSpan?.project_id doesn't match a known project), projectSlug becomes an empty string, leading to the malformed URL. The useRelease hook's enabled condition should be updated to also check for a defined project.slug to prevent these invalid requests.
static/app/views/insights/database/views/databaseSpanSummaryPage.spec.tsx#L169-L170
static/app/views/insights/common/components/spanDescription.tsx#L78-L84
Was this report helpful? Give feedback by reacting with 👍 or 👎
We can remove eap conditions now that insights+eap is at 100%.
This PR additionally removes the
useFullSpanFromTracefeature in the span description component. This isn't needed for a few reasons.